• Russell King's avatar
    i2c: mux: pca954x: fix i2c mux selection caching · 7f638c1c
    Russell King authored
    smbus functions return -ve on error, 0 on success.  However,
    __i2c_transfer() have a different return signature - -ve on error, or
    number of buffers transferred (which may be zero or greater.)
    
    The upshot of this is that the sense of the test is reversed when using
    the mux on a bus supporting the master_xfer method: we cache the value
    and never retry if we fail to transfer any buffers, but if we succeed,
    we clear the cached value.
    
    Fix this by making pca954x_reg_write() return a negative error code for
    all failure cases.
    
    Fixes: 463e8f84 ("i2c: mux: pca954x: retry updating the mux selection on failure")
    Acked-by: default avatarPeter Rosin <peda@axentia.se>
    Signed-off-by: default avatarRussell King <rmk+kernel@armlinux.org.uk>
    Signed-off-by: default avatarWolfram Sang <wsa@the-dreams.de>
    7f638c1c
i2c-mux-pca954x.c 9.14 KB