• Sifan Naeem's avatar
    [media] rc: img-ir: fix error in parameters passed to irq_free() · 80ccf4ad
    Sifan Naeem authored
    img_ir_remove() passes a pointer to the ISR function as the 2nd
    parameter to irq_free() instead of a pointer to the device data
    structure.
    This issue causes unloading img-ir module to fail with the below
    warning after building and loading img-ir as a module.
    
    WARNING: CPU: 2 PID: 155 at ../kernel/irq/manage.c:1278
    __free_irq+0xb4/0x214() Trying to free already-free IRQ 58
    Modules linked in: img_ir(-)
    CPU: 2 PID: 155 Comm: rmmod Not tainted 3.14.0 #55 ...
    Call Trace:
    ...
    [<8048d420>] __free_irq+0xb4/0x214
    [<8048d6b4>] free_irq+0xac/0xf4
    [<c009b130>] img_ir_remove+0x54/0xd4 [img_ir] [<8073ded0>]
    platform_drv_remove+0x30/0x54 ...
    
    Fixes: 160a8f8a ("[media] rc: img-ir: add base driver")
    Signed-off-by: default avatarSifan Naeem <sifan.naeem@imgtec.com>
    Cc: <stable@vger.kernel.org> # 3.15+
    Acked-by: default avatarJames Hogan <james.hogan@imgtec.com>
    Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
    80ccf4ad
img-ir-core.c 5.23 KB