• Sage Weil's avatar
    ceph: allow writeback of snapped pages older than 'oldest' snapc · 80e755fe
    Sage Weil authored
    On snap deletion, we don't regenerate ceph_cap_snaps for inodes with dirty
    pages because deletion does not affect metadata writeback.  However, we
    did run into problems when we went to write back the pages because the
    'oldest' snapc is determined by the oldest cap_snap, and that may be the
    newer snapc that reflects the deletion.  This caused confusion and an
    infinite loop in ceph_update_writeable_page().
    
    Change the snapc checks to allow writeback of any snapc that is equal to
    OR older than the 'oldest' snapc.
    
    When there are no cap_snaps, we were also using the realm's latest snapc
    for writeback, which complicates ceph_put_wrbufffer_cap_refs().  Instead,
    use i_head_snapc, the most snapc used for the most recent ('head') data.
    This makes the writeback snapc (ceph_osd_request.r_snapc) _always_ match a
    capsnap or i_head_snapc.
    
    Also, in writepags_finish(), drop the snapc referenced by the _page_
    and do not assume it matches the request snapc (it may not anymore).
    Signed-off-by: default avatarSage Weil <sage@newdream.net>
    80e755fe
addr.c 32.1 KB