• Kirill Kuvaldin's avatar
    isofs: mounting to regular file may succeed · 817794e0
    Kirill Kuvaldin authored
    It turned out that mounting a corrupted ISO image to a regular file may
    succeed, e.g.  if an image was prepared as follows:
    
    $ dd if=correct.iso of=bad.iso bs=4k count=8
    
    We then can mount it to a regular file:
    
    # mount -o loop -t iso9660 bad.iso /tmp/file
    
    But mounting it to a directory fails with -ENOTDIR, simply because
    the root directory inode doesn't have S_IFDIR set and the condition
    in graft_tree() is met:
    
    	if (S_ISDIR(nd->dentry->d_inode->i_mode) !=
    	      S_ISDIR(mnt->mnt_root->d_inode->i_mode))
    		return -ENOTDIR
    
    This is because the root directory inode was read from an incorrect
    block. It's supposed to be read from sbi->s_firstdatazone, which is
    an absolute value and gets messed up in the case of an incorrect image.
    
    In order to somehow circumvent this we have to check that the root
    directory inode is actually a directory after all.
    Signed-off-by: default avatarKirill Kuvaldin <kuvkir@epsmu.com>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    817794e0
inode.c 36.2 KB