• Heesub Shin's avatar
    zsmalloc: fix fatal corruption due to wrong size class selection · 81da9b13
    Heesub Shin authored
    There is no point in overriding the size class below.  It causes fatal
    corruption on the next chunk on the 3264-bytes size class, which is the
    last size class that is not huge.
    
    For example, if the requested size was exactly 3264 bytes, current
    zsmalloc allocates and returns a chunk from the size class of 3264 bytes,
    not 4096.  User access to this chunk may overwrite head of the next
    adjacent chunk.
    
    Here is the panic log captured when freelist was corrupted due to this:
    
        Kernel BUG at ffffffc00030659c [verbose debug info unavailable]
        Internal error: Oops - BUG: 96000006 [#1] PREEMPT SMP
        Modules linked in:
        exynos-snapshot: core register saved(CPU:5)
        CPUMERRSR: 0000000000000000, L2MERRSR: 0000000000000000
        exynos-snapshot: context saved(CPU:5)
        exynos-snapshot: item - log_kevents is disabled
        CPU: 5 PID: 898 Comm: kswapd0 Not tainted 3.10.61-4497415-eng #1
        task: ffffffc0b8783d80 ti: ffffffc0b71e8000 task.ti: ffffffc0b71e8000
        PC is at obj_idx_to_offset+0x0/0x1c
        LR is at obj_malloc+0x44/0xe8
        pc : [<ffffffc00030659c>] lr : [<ffffffc000306604>] pstate: a0000045
        sp : ffffffc0b71eb790
        x29: ffffffc0b71eb790 x28: ffffffc00204c000
        x27: 000000000001d96f x26: 0000000000000000
        x25: ffffffc098cc3500 x24: ffffffc0a13f2810
        x23: ffffffc098cc3501 x22: ffffffc0a13f2800
        x21: 000011e1a02006e3 x20: ffffffc0a13f2800
        x19: ffffffbc02a7e000 x18: 0000000000000000
        x17: 0000000000000000 x16: 0000000000000feb
        x15: 0000000000000000 x14: 00000000a01003e3
        x13: 0000000000000020 x12: fffffffffffffff0
        x11: ffffffc08b264000 x10: 00000000e3a01004
        x9 : ffffffc08b263fea x8 : ffffffc0b1e611c0
        x7 : ffffffc000307d24 x6 : 0000000000000000
        x5 : 0000000000000038 x4 : 000000000000011e
        x3 : ffffffbc00003e90 x2 : 0000000000000cc0
        x1 : 00000000d0100371 x0 : ffffffbc00003e90
    Reported-by: default avatarSooyong Suk <s.suk@samsung.com>
    Signed-off-by: default avatarHeesub Shin <heesub.shin@samsung.com>
    Tested-by: default avatarSooyong Suk <s.suk@samsung.com>
    Acked-by: default avatarMinchan Kim <minchan@kernel.org>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    81da9b13
zsmalloc.c 45.5 KB