• Linas Vepstas's avatar
    [PATCH] pci: initialize struct pci_dev.error_state · 82081797
    Linas Vepstas authored
    The pci channel state is currently uninitialized, thus there are two ways
    of indicating that "everything's OK": 0 and 1.  This is a bit of a burden.
    
    If a devce driver wants to check if the pci channel is in a working or a
    disconnected state, the driver writer must perform checks similar to
    
       if((pdev->error_state != 0) &&
          (pdev->error_state != pci_channel_io_normal)) {
             whatever();
       }
    
    which is rather akward.  The first check is needed because stuct pci_dev is
    inited to all-zeros.  The scond is needed because the error recovery will
    set the state to pci_channel_io_normal (which is not zero).
    
    This patch fixes this awkwardness.
    Signed-off-by: default avatarLinas Vepstas <linas@austin.ibm.com>
    Cc: Greg KH <greg@kroah.com>
    Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
    82081797
probe.c 28.5 KB