• Ilija Hadzic's avatar
    drm/radeon: fix a rare case of double kfree · 8474b1ab
    Ilija Hadzic authored
    commit 1da80cfa upstream.
    
    If one (but not both) allocations of p->chunks[].kpage[]
    in radeon_cs_parser_init fail, the error path will free
    the successfully allocated page, but leave a stale pointer
    value in the kpage[] field. This will later cause a
    double-free when radeon_cs_parser_fini is called.
    This patch fixes the issue by forcing both pointers to NULL
    after kfree in the error path.
    
    The circumstances under which the problem happens are very
    rare. The card must be AGP and the system must run out of
    kmalloc area just at the right time so that one allocation
    succeeds, while the other fails.
    Signed-off-by: default avatarIlija Hadzic <ihadzic@research.bell-labs.com>
    Cc: Herton Ronaldo Krzesinski <herton.krzesinski@canonical.com>
    Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
    [bwh: Backported to 3.2: s/p->chunk_ib_idx/i/]
    Signed-off-by: default avatarBen Hutchings <ben@decadent.org.uk>
    8474b1ab
radeon_cs.c 10.1 KB