• Philip Pettersson's avatar
    packet: fix race condition in packet_set_ring · 84ac7260
    Philip Pettersson authored
    When packet_set_ring creates a ring buffer it will initialize a
    struct timer_list if the packet version is TPACKET_V3. This value
    can then be raced by a different thread calling setsockopt to
    set the version to TPACKET_V1 before packet_set_ring has finished.
    
    This leads to a use-after-free on a function pointer in the
    struct timer_list when the socket is closed as the previously
    initialized timer will not be deleted.
    
    The bug is fixed by taking lock_sock(sk) in packet_setsockopt when
    changing the packet version while also taking the lock at the start
    of packet_set_ring.
    
    Fixes: f6fb8f10 ("af-packet: TPACKET_V3 flexible buffer implementation.")
    Signed-off-by: default avatarPhilip Pettersson <philip.pettersson@gmail.com>
    Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    84ac7260
af_packet.c 106 KB