• Mark Rutland's avatar
    arm64: perf: reject CHAIN events at creation time · 853e2dac
    Mark Rutland authored
    Currently it's possible for a user to open CHAIN events arbitrarily,
    which we previously tried to rule out in commit:
    
      ca2b4972 ("arm64: perf: Reject stand-alone CHAIN events for PMUv3")
    
    Which allowed the events to be opened, but prevented them from being
    scheduled by by using an arm_pmu::filter_match hook to reject the
    relevant events.
    
    The CHAIN event filtering in the arm_pmu::filter_match hook was silently
    removed in commit:
    
      bd275681 ("perf: Rewrite core context handling")
    
    As a result, it's now possible for users to open CHAIN events, and for
    these to be installed arbitrarily.
    
    Fix this by rejecting CHAIN events at creation time. This avoids the
    creation of events which will never count, and doesn't require using the
    dynamic filtering.
    
    Attempting to open a CHAIN event (0x1e) will now be rejected:
    
    | # ./perf stat -e armv8_pmuv3/config=0x1e/ ls
    | perf
    |
    |  Performance counter stats for 'ls':
    |
    |    <not supported>      armv8_pmuv3/config=0x1e/
    |
    |        0.002197470 seconds time elapsed
    |
    |        0.000000000 seconds user
    |        0.002294000 seconds sys
    
    Other events (e.g. CPU_CYCLES / 0x11) will open as usual:
    
    | # ./perf stat -e armv8_pmuv3/config=0x11/ ls
    | perf
    |
    |  Performance counter stats for 'ls':
    |
    |            2538761      armv8_pmuv3/config=0x11/
    |
    |        0.002227330 seconds time elapsed
    |
    |        0.002369000 seconds user
    |        0.000000000 seconds sys
    
    Fixes: bd275681 ("perf: Rewrite core context handling")
    Signed-off-by: default avatarMark Rutland <mark.rutland@arm.com>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Ravi Bangoria <ravi.bangoria@amd.com>
    Cc: Will Deacon <will@kernel.org>
    Link: https://lore.kernel.org/r/20230216141240.3833272-3-mark.rutland@arm.comSigned-off-by: default avatarWill Deacon <will@kernel.org>
    853e2dac
perf_event.c 44.5 KB