• Jiaqi Yan's avatar
    mm/memory-failure: refactor log format in soft offline code · 865319f7
    Jiaqi Yan authored
    Patch series "Userspace controls soft-offline pages", v6.
    
    Correctable memory errors are very common on servers with large amount of
    memory, and are corrected by ECC, but with two pain points to users:
    
    1. Correction usually happens on the fly and adds latency overhead
    2. Not-fully-proved theory states excessive correctable memory
       errors can develop into uncorrectable memory error.
    
    Soft offline is kernel's additional solution for memory pages having
    (excessive) corrected memory errors.  Impacted page is migrated to healthy
    page if it is in use, then the original page is discarded for any future
    use.
    
    The actual policy on whether (and when) to soft offline should be
    maintained by userspace, especially in case of an 1G HugeTLB page. 
    Soft-offline dissolves the HugeTLB page, either in-use or free, into
    chunks of 4K pages, reducing HugeTLB pool capacity by 1 hugepage.  If
    userspace has not acknowledged such behavior, it may be surprised when
    later mmap hugepages MAP_FAILED due to lack of hugepages.  In case of a
    transparent hugepage, it will be split into 4K pages as well; userspace
    will stop enjoying the transparent performance.
    
    In addition, discarding the entire 1G HugeTLB page only because of
    corrected memory errors sounds very costly and kernel better not doing
    under the hood.  But today there are at least 2 such cases:
    
    1. GHES driver sees both GHES_SEV_CORRECTED and
       CPER_SEC_ERROR_THRESHOLD_EXCEEDED after parsing CPER.
    2. RAS Correctable Errors Collector counts correctable errors per
       PFN and when the counter for a PFN reaches threshold
    
    In both cases, userspace has no control of the soft offline performed by
    kernel's memory failure recovery.
    
    This patch series give userspace the control of softofflining any page:
    kernel only soft offlines raw page / transparent hugepage / HugeTLB
    hugepage if userspace has agreed to.  The interface to userspace is a new
    sysctl called enable_soft_offline under /proc/sys/vm.  By default
    enable_soft_line is 1 to preserve existing behavior in kernel.
    
    
    This patch (of 4):
    
    Logs from soft_offline_page and soft_offline_in_use_page have different
    formats than majority of the memory failure code:
    
      "Memory failure: 0x${pfn}: ${lower_case_message}"
    
    Convert them to the following format:
    
      "Soft offline: 0x${pfn}: ${lower_case_message}"
    
    No functional change in this commit.
    
    Link: https://lkml.kernel.org/r/20240626050818.2277273-1-jiaqiyan@google.com
    Link: https://lkml.kernel.org/r/20240626050818.2277273-2-jiaqiyan@google.comSigned-off-by: default avatarJiaqi Yan <jiaqiyan@google.com>
    Acked-by: default avatarMiaohe Lin <linmiaohe@huawei.com>
    Reviewed-by: default avatarLance Yang <ioworker0@gmail.com>
    Cc: David Rientjes <rientjes@google.com>
    Cc: Frank van der Linden <fvdl@google.com>
    Cc: Jane Chu <jane.chu@oracle.com>
    Cc: Jonathan Corbet <corbet@lwn.net>
    Cc: Muchun Song <muchun.song@linux.dev>
    Cc: Naoya Horiguchi <nao.horiguchi@gmail.com>
    Cc: Oscar Salvador <osalvador@suse.de>
    Cc: Randy Dunlap <rdunlap@infradead.org>
    Cc: Shuah Khan <shuah@kernel.org>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    865319f7
memory-failure.c 74.9 KB