• Jerome Brunet's avatar
    ASoC: meson: axg-tdm-interface: manage formatters in trigger · bf5e4887
    Jerome Brunet authored
    So far, the formatters have been reset/enabled using the .prepare()
    callback. This was done in this callback because walking the formatters use
    a mutex so it could not be done in .trigger(), which is atomic by default.
    
    It turns out there is a problem on capture path of the AXG series.
    The FIFO may get out of sync with the TDM decoder if the IP are not enabled
    in a specific order. The FIFO must be enabled before the formatter starts
    producing data. IOW, we must deal with FE before the BE. The .prepare()
    callback is called on the BEs before the FE so it is not OK for the AXG.
    
    The .trigger() callback order can be configured, and it deals with the FE
    before the BEs by default. To solve our problem, we just need to start and
    stop the formatters from the .trigger() callback. It is OK do so now that
    the links have been made 'nonatomic' in the card driver.
    Signed-off-by: default avatarJerome Brunet <jbrunet@baylibre.com>
    Link: https://lore.kernel.org/r/20211020114217.133153-3-jbrunet@baylibre.comSigned-off-by: default avatarMark Brown <broonie@kernel.org>
    bf5e4887
axg-tdm-interface.c 14 KB