• Baoquan He's avatar
    mm/page_alloc.c: only tune sysctl_lowmem_reserve_ratio value once when changing it · 86aaf255
    Baoquan He authored
    Patch series "improvements about lowmem_reserve and /proc/zoneinfo", v2.
    
    This patch (of 3):
    
    When people write to /proc/sys/vm/lowmem_reserve_ratio to change
    sysctl_lowmem_reserve_ratio[], setup_per_zone_lowmem_reserve() is called
    to recalculate all ->lowmem_reserve[] for each zone of all nodes as below:
    
    static void setup_per_zone_lowmem_reserve(void)
    {
    ...
    	for_each_online_pgdat(pgdat) {
    		for (j = 0; j < MAX_NR_ZONES; j++) {
    			...
    			while (idx) {
    				...
    				if (sysctl_lowmem_reserve_ratio[idx] < 1) {
    					sysctl_lowmem_reserve_ratio[idx] = 0;
    					lower_zone->lowmem_reserve[j] = 0;
                                    } else {
    				...
    			}
    		}
    	}
    }
    
    Meanwhile, here, sysctl_lowmem_reserve_ratio[idx] will be tuned if its
    value is smaller than '1'.  As we know, sysctl_lowmem_reserve_ratio[] is
    set for zone without regarding to which node it belongs to.  That means
    the tuning will be done on all nodes, even though it has been done in the
    first node.
    
    And the tuning will be done too even when init_per_zone_wmark_min() calls
    setup_per_zone_lowmem_reserve(), where actually nobody tries to change
    sysctl_lowmem_reserve_ratio[].
    
    So now move the tuning into lowmem_reserve_ratio_sysctl_handler(), to make
    code logic more reasonable.
    Signed-off-by: default avatarBaoquan He <bhe@redhat.com>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com>
    Cc: Michal Hocko <mhocko@kernel.org>
    Cc: Baoquan He <bhe@redhat.com>
    Cc: Mel Gorman <mgorman@techsingularity.net>
    Cc: David Rientjes <rientjes@google.com>
    Link: http://lkml.kernel.org/r/20200402140113.3696-1-bhe@redhat.com
    Link: http://lkml.kernel.org/r/20200402140113.3696-2-bhe@redhat.comSigned-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    86aaf255
page_alloc.c 241 KB