• Dave Hansen's avatar
    x86/cpu: Fix duplicated X86_BUG(9) macro · 8709ed4d
    Dave Hansen authored
    cpufeatures.h currently defines X86_BUG(9) twice on 32-bit:
    
    	#define X86_BUG_NULL_SEG        X86_BUG(9) /* Nulling a selector preserves the base */
    	...
    	#ifdef CONFIG_X86_32
    	#define X86_BUG_ESPFIX          X86_BUG(9) /* "" IRET to 16-bit SS corrupts ESP/RSP high bits */
    	#endif
    
    I think what happened was that this added the X86_BUG_ESPFIX, but
    in an #ifdef below most of the bugs:
    
    	58a5aac5 x86/entry/32: Introduce and use X86_BUG_ESPFIX instead of paravirt_enabled
    
    Then this came along and added X86_BUG_NULL_SEG, but collided
    with the earlier one that did the bug below the main block
    defining all the X86_BUG()s.
    
    	7a5d6704 x86/cpu: Probe the behavior of nulling out a segment at boot time
    Signed-off-by: default avatarDave Hansen <dave.hansen@linux.intel.com>
    Acked-by: default avatarAndy Lutomirski <luto@kernel.org>
    Cc: Andy Lutomirski <luto@amacapital.net>
    Cc: Borislav Petkov <bp@alien8.de>
    Cc: Brian Gerst <brgerst@gmail.com>
    Cc: Dave Hansen <dave@sr71.net>
    Cc: Denys Vlasenko <dvlasenk@redhat.com>
    Cc: H. Peter Anvin <hpa@zytor.com>
    Cc: Josh Poimboeuf <jpoimboe@redhat.com>
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Cc: stable@vger.kernel.org
    Link: http://lkml.kernel.org/r/20160618001503.CEE1B141@viggo.jf.intel.comSigned-off-by: default avatarIngo Molnar <mingo@kernel.org>
    8709ed4d
cpufeatures.h 17.6 KB