• Maxim Kiselev's avatar
    gpio: pcf857x: Fix missing first interrupt · a8002a35
    Maxim Kiselev authored
    If no n_latch value will be provided at driver probe then all pins will
    be used as an input:
    
        gpio->out = ~n_latch;
    
    In that case initial state for all pins is "one":
    
        gpio->status = gpio->out;
    
    So if pcf857x IRQ happens with change pin value from "zero" to "one"
    then we miss it, because of "one" from IRQ and "one" from initial state
    leaves corresponding pin unchanged:
    change = (gpio->status ^ status) & gpio->irq_enabled;
    
    The right solution will be to read actual state at driver probe.
    
    Cc: stable@vger.kernel.org
    Fixes: 6e20a0a4 ("gpio: pcf857x: enable gpio_to_irq() support")
    Signed-off-by: default avatarMaxim Kiselev <bigunclemax@gmail.com>
    Signed-off-by: default avatarBartosz Golaszewski <bgolaszewski@baylibre.com>
    a8002a35
gpio-pcf857x.c 11.7 KB