• Mingzhe Zou's avatar
    bcache: fixup multiple threads crash · 887554ab
    Mingzhe Zou authored
    When multiple threads to check btree nodes in parallel, the main
    thread wait for all threads to stop or CACHE_SET_IO_DISABLE flag:
    
    wait_event_interruptible(check_state->wait,
                             atomic_read(&check_state->started) == 0 ||
                             test_bit(CACHE_SET_IO_DISABLE, &c->flags));
    
    However, the bch_btree_node_read and bch_btree_node_read_done
    maybe call bch_cache_set_error, then the CACHE_SET_IO_DISABLE
    will be set. If the flag already set, the main thread return
    error. At the same time, maybe some threads still running and
    read NULL pointer, the kernel will crash.
    
    This patch change the event wait condition, the main thread must
    wait for all threads to stop.
    
    Fixes: 8e710227 ("bcache: make bch_btree_check() to be multithreaded")
    Signed-off-by: default avatarMingzhe Zou <mingzhe.zou@easystack.cn>
    Cc: stable@vger.kernel.org # v5.7+
    Signed-off-by: default avatarColy Li <colyli@suse.de>
    887554ab
btree.c 63.1 KB