• Palmer Dabbelt's avatar
    Merge patch series "RISC-V: Fixes for riscv_has_extension[un]likely()'s alternative dependency" · be693ef2
    Palmer Dabbelt authored
    Conor Dooley <conor.dooley@microchip.com> says:
    
    Here's my attempt at fixing both the use of an FPU on XIP kernels and
    the issue that Jason ran into where CONFIG_FPU, which needs the
    alternatives frame work for has_fpu() checks, could be enabled without
    the alternatives actually being present.
    
    For the former, a "slow" fallback that does not use alternatives is
    added to riscv_has_extension_[un]likely() that can be used with XIP.
    Obviously, we want to make use of Jisheng's alternatives based approach
    where possible, so any users of riscv_has_extension_[un]likely() will
    want to make sure that they select RISCV_ALTERNATIVE.
    If they don't however, they'll hit the fallback path which (should,
    sparing a silly mistake from me!) behave in the same way, thus
    succeeding silently. Sounds like a
    
    To prevent "depends on !XIP_KERNEL; select RISCV_ALTERNATIVE" spreading
    like the plague through the various places that want to check for the
    presence of extensions, and sidestep the potential silent "success"
    mentioned above, all users RISCV_ALTERNATIVE are converted from selects
    to dependencies, with the option being selected for all !XIP_KERNEL
    builds.
    
    I know that the VDSO was a key place that Jisheng wanted to use the new
    helper rather than static branches, and I think the fallback path
    should not cause issues there.
    
    See the thread at [1] for the prior discussion.
    
    1 - https://lore.kernel.org/linux-riscv/20230128172856.3814-1-jszhang@kernel.org/T/#m21390d570997145d31dd8bb95002fd61f99c6573
    
    [Palmer: these were also merged into fixes, but there's a cleanup that
    depends on the merge so I'm taking it into for-next as well.]
    
    * b4-shazam-merge:
      RISC-V: always select RISCV_ALTERNATIVE for non-xip kernels
      RISC-V: add non-alternative fallback for riscv_has_extension_[un]likely()
    
    Link: https://lore.kernel.org/r/20230324100538.3514663-1-conor.dooley@microchip.comSigned-off-by: default avatarPalmer Dabbelt <palmer@rivosinc.com>
    
    * commit '1ee7fc3f':
      RISC-V: always select RISCV_ALTERNATIVE for non-xip kernels
      RISC-V: add non-alternative fallback for riscv_has_extension_[un]likely()
    be693ef2
hwcap.h 3.02 KB