• Christian Brauner's avatar
    net: Use generic ns_common::count · 8b8f3e66
    Christian Brauner authored
    Switch over network namespaces to use the newly introduced common lifetime
    counter.
    Network namespaces have an additional counter named "passive". This counter
    does not guarantee that the network namespace is not already de-initialized
    and so isn't concerned with the actual lifetime of the network namespace;
    only the "count" counter is. So the latter is moved into struct ns_common.
    
    Currently every namespace type has its own lifetime counter which is stored
    in the specific namespace struct. The lifetime counters are used
    identically for all namespaces types. Namespaces may of course have
    additional unrelated counters and these are not altered.
    
    This introduces a common lifetime counter into struct ns_common. The
    ns_common struct encompasses information that all namespaces share. That
    should include the lifetime counter since its common for all of them.
    
    It also allows us to unify the type of the counters across all namespaces.
    Most of them use refcount_t but one uses atomic_t and at least one uses
    kref. Especially the last one doesn't make much sense since it's just a
    wrapper around refcount_t since 2016 and actually complicates cleanup
    operations by having to use container_of() to cast the correct namespace
    struct out of struct ns_common.
    
    Having the lifetime counter for the namespaces in one place reduces
    maintenance cost. Not just because after switching all namespaces over we
    will have removed more code than we added but also because the logic is
    more easily understandable and we indicate to the user that the basic
    lifetime requirements for all namespaces are currently identical.
    Signed-off-by: default avatarKirill Tkhai <ktkhai@virtuozzo.com>
    Reviewed-by: default avatarKees Cook <keescook@chromium.org>
    Acked-by: default avatarChristian Brauner <christian.brauner@ubuntu.com>
    [christian.brauner@ubuntu.com: rewrite commit]
    Link: https://lore.kernel.org/r/159644977635.604812.1319877322927063560.stgit@localhost.localdomainSigned-off-by: default avatarChristian Brauner <christian.brauner@ubuntu.com>
    8b8f3e66
inet_timewait_sock.c 8.89 KB