• Sebastian Andrzej Siewior's avatar
    usb: musb: dsps: move try_idle to start hook · 8b9fcce2
    Sebastian Andrzej Siewior authored
    The timer is initialized right after musb is probed. There is actually
    no need to have this timer running because _nothing_ will happen until
    we have the gadget loaded. Also we need this timer only if we run in OTG
    mode _and_ we need it also after the gadget has been replaced with
    another one.
    
    I've been looking at am35x.c, da8xx.c, omap2430.c, tusb6010.c. da8xx
    seem to have the same problem as dsps and doing mostly the same thing.
    tusb6010 seem to do something different and do some actual "idle / power
    saving" work so I am not too comfortable to remove
    musb_platform_try_idle() from musb_gadget_setup().
    
    Therefore this patch does not start the timer if there is no gadget
    active (which is at musb_gadget_setup() at time). In order to have the
    timer active after the gadget is loaded it will be triggered from
    dsps_musb_enable().
    
    Cc: stable@vger.kernel.org # v3.11
    Signed-off-by: default avatarSebastian Andrzej Siewior <bigeasy@linutronix.de>
    Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
    8b9fcce2
musb_dsps.c 17.1 KB