• Namhyung Kim's avatar
    perf test: Reorder event name checks in stat STD output linter · 8d3df7c3
    Namhyung Kim authored
    On AMD machines, the perf stat STD output test failed like below:
    
      $ sudo ./perf test -v 98
       98: perf stat STD output linter                                     :
      --- start ---
      test child forked, pid 1841901
      Checking STD output: no argswrong event metric.
        expected 'GHz' in 108,121 stalled-cycles-frontend  # 10.88% frontend cycles idle
      test child finished with -1
      ---- end ----
      perf stat STD output linter: FAILED!
    
    This is because there are stalled-cycles-{frontend,backend} events are
    used by default.  The current logic checks the event_name array to find
    which event it's running.  But 'cycles' event comes before those stalled
    cycles event and it matches first.  So it tries to find 'GHz' metric
    in the output (which is for the 'cycles') and fails.
    
    Move the stalled-cycles-{frontend,backend} events before 'cycles' so
    that it can find the stalled cycles events first.
    
    Also add a space after 'no args' test name for consistency.
    
    Fixes: 99a04a48 ("perf test: Add test case for the standard 'perf stat' output")
    Acked-by: default avatarIan Rogers <irogers@google.com>
    Cc: Kan Liang <kan.liang@linux.intel.com>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Adrian Hunter <adrian.hunter@intel.com>
    Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
    Cc: Jiri Olsa <jolsa@kernel.org>
    Cc: Ingo Molnar <mingo@kernel.org>
    Link: https://lore.kernel.org/r/20230623230139.985594-1-namhyung@kernel.orgSigned-off-by: default avatarNamhyung Kim <namhyung@kernel.org>
    8d3df7c3
stat_output.sh 3.38 KB