• Chris Wilson's avatar
    drm/i915: Tightly scope intel_encoder to prevent invalid use · 8e647a27
    Chris Wilson authored
    We reset intel_encoder for every matching encoder whilst iterating over
    the encoders attached to this crtc when changing mode. As such in a
    cloned configuration intel_encoder may not correspond to the correct
    is_edp encoder.
    
    By scoping intel_encoder to the loop, not only is the compiler able to
    spot this mistake, we also improve readiability for ourselves.
    [It might not be a mistake, within this function it is unclear as to
    whether it is permissable for eDP to be cloned...]
    Signed-off-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
    8e647a27
intel_display.c 178 KB