• Joe Perches's avatar
    checkpatch: Warn on code with 6+ tab indentation · 8eef05dd
    Joe Perches authored
    Overly indented code should be refactored.
    
    Suggest refactoring excessive indentation of of
    if/else/for/do/while/switch statements.
    
    For example:
    
    $ cat t.c
    #include <stdio.h>
    #include <stdlib.h>
    
    int main(int argc, char **argv)
    {
    
    	if (1)
    		if (2)
    			if (3)
    				if (4)
    					if (5)
    						if (6)
    							if (7)
    								if (8)
    									;
    	return 0;
    }
    
    $ ./scripts/checkpatch.pl -f t.c
    WARNING: Too many leading tabs - consider code refactoring
    #12: FILE: t.c:12:
    +						if (6)
    
    WARNING: Too many leading tabs - consider code refactoring
    #13: FILE: t.c:13:
    +							if (7)
    
    WARNING: Too many leading tabs - consider code refactoring
    #14: FILE: t.c:14:
    +								if (8)
    
    total: 0 errors, 3 warnings, 17 lines checked
    
    t.c has style problems, please review.
    
    If any of these errors are false positives, please report
    them to the maintainer, see CHECKPATCH in MAINTAINERS.
    Signed-off-by: default avatarJoe Perches <joe@perches.com>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    8eef05dd
checkpatch.pl 91 KB