• Hans Verkuil's avatar
    [media] cec: race fix: don't return -ENONET in cec_receive() · b94aac64
    Hans Verkuil authored
    When calling CEC_RECEIVE do not check if the adapter is configured.
    Typically CEC_RECEIVE is called after a select() and if that indicates
    that there are messages in the receive queue, then you should always be
    able to dequeue a message.
    
    The race condition here is that a message has been received and is
    queued, so select() tells userspace that a message is available. But
    before the application calls CEC_RECEIVE the adapter is unconfigured
    (e.g. the HDMI cable is removed). Now select will always report that
    there is a message, but calling CEC_RECEIVE will always return -ENONET
    because the adapter is no longer configured and so will never actually
    dequeue the message.
    
    There is really no need for this check, and in fact the ENONET error
    code was never documented for CEC_RECEIVE. This may have been a left-over
    of old code that was never updated.
    Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
    Cc: <stable@vger.kernel.org>      # for v4.10 and up
    Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
    b94aac64
cec-api.c 15 KB