• Hector Martin's avatar
    pinctrl: apple: Use a raw spinlock for the regmap · 83969805
    Hector Martin authored
    The irqchip ops are called with a raw spinlock held, so the subsequent
    regmap usage cannot use a plain spinlock.
    
    spi-hid-apple-of spi0.0: spihid_apple_of_probe:74
    
    =============================
    [ BUG: Invalid wait context ]
    5.18.0-asahi-00176-g0fa3ab03bdea #1337 Not tainted
    -----------------------------
    kworker/u20:3/86 is trying to lock:
    ffff8000166b5018 (pinctrl_apple_gpio:462:(&regmap_config)->lock){....}-{3:3}, at: regmap_lock_spinlock+0x18/0x30
    other info that might help us debug this:
    context-{5:5}
    7 locks held by kworker/u20:3/86:
     #0: ffff800017725d48 ((wq_completion)events_unbound){+.+.}-{0:0}, at: process_one_work+0x1c8/0x670
     #1: ffff80001e33bdd0 (deferred_probe_work){+.+.}-{0:0}, at: process_one_work+0x1c8/0x670
     #2: ffff800017d629a0 (&dev->mutex){....}-{4:4}, at: __device_attach+0x30/0x17c
     #3: ffff80002414e618 (&ctlr->add_lock){+.+.}-{4:4}, at: spi_add_device+0x40/0x80
     #4: ffff800024116990 (&dev->mutex){....}-{4:4}, at: __device_attach+0x30/0x17c
     #5: ffff800022d4be58 (request_class){+.+.}-{4:4}, at: __setup_irq+0xa8/0x720
     #6: ffff800022d4bcc8 (lock_class){....}-{2:2}, at: __setup_irq+0xcc/0x720
    
    Fixes: a0f160ff ("pinctrl: add pinctrl/GPIO driver for Apple SoCs")
    Signed-off-by: default avatarHector Martin <marcan@marcan.st>
    Link: https://lore.kernel.org/r/20220524142206.18833-1-marcan@marcan.stSigned-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
    83969805
pinctrl-apple-gpio.c 14.9 KB