• Philipp Reisner's avatar
    drbd: close race between drbd_set_role and drbd_connect · 13c76aba
    Philipp Reisner authored
    drbd_set_role(, R_PRIMARY, ) does the state change to Primary,
    some more housekeeping, and possibly generates a new UUID set.
    
    All of this holding the "state_mutex".
    
    The connection handshake involves sending of various state information,
    including the current data generation UUID set, and two connection
    state changes from C_WF_CONNECTION to C_WF_REPORT_PARAMS further to
    a number of different outcomes, resync being one of them.
    
    If the connection handshake happens between the state change to Primary
    and the generation of the new UUIDs, the resync decision based on the
    old UUID set may be confused, depending on circumstances.
    
    Make sure that, before we do the handshake, any promotion to Primary
    role will either be complete (including the housekeeping stuff), or can
    see, and serialize with, the ongoing handshake, based on the
    "STATE_SENT" bit, which is set when we start the handshake, and cleared
    only when we leave C_WF_REPORT_PARAMS again.
    Signed-off-by: default avatarPhilipp Reisner <philipp.reisner@linbit.com>
    Signed-off-by: default avatarLars Ellenberg <lars.ellenberg@linbit.com>
    13c76aba
drbd_receiver.c 146 KB