• Sabyrzhan Tasbolatov's avatar
    smackfs: restrict bytes count in smackfs write functions · 7ef4c19d
    Sabyrzhan Tasbolatov authored
    syzbot found WARNINGs in several smackfs write operations where
    bytes count is passed to memdup_user_nul which exceeds
    GFP MAX_ORDER. Check count size if bigger than PAGE_SIZE.
    
    Per smackfs doc, smk_write_net4addr accepts any label or -CIPSO,
    smk_write_net6addr accepts any label or -DELETE. I couldn't find
    any general rule for other label lengths except SMK_LABELLEN,
    SMK_LONGLABEL, SMK_CIPSOMAX which are documented.
    
    Let's constrain, in general, smackfs label lengths for PAGE_SIZE.
    Although fuzzer crashes write to smackfs/netlabel on 0x400000 length.
    
    Here is a quick way to reproduce the WARNING:
    python -c "print('A' * 0x400000)" > /sys/fs/smackfs/netlabel
    
    Reported-by: syzbot+a71a442385a0b2815497@syzkaller.appspotmail.com
    Signed-off-by: default avatarSabyrzhan Tasbolatov <snovitoll@gmail.com>
    Signed-off-by: default avatarCasey Schaufler <casey@schaufler-ca.com>
    7ef4c19d
smackfs.c 69.4 KB