• Eric Paris's avatar
    SELinux: remove needless sel_div function · 92ae9e82
    Eric Paris authored
    I'm not really sure what the idea behind the sel_div function is, but it's
    useless.  Since a and b are both unsigned, it's impossible for a % b < 0.
    That means that part of the function never does anything.  Thus it's just a
    normal /.  Just do that instead.  I don't even understand what that operation
    was supposed to mean in the signed case however....
    
    If it was signed:
    sel_div(-2, 4) == ((-2 / 4) - ((-2 % 4) < 0))
    		  ((0)      - ((-2)     < 0))
    		  ((0)      - (1))
    		  (-1)
    
    What actually happens:
    sel_div(-2, 4) == ((18446744073709551614 / 4) - ((18446744073709551614 % 4) < 0))
    		  ((4611686018427387903)      - ((2 < 0))
    		  (4611686018427387903        - 0)
    		  ((unsigned int)4611686018427387903)
    		  (4294967295)
    
    Neither makes a whole ton of sense to me.  So I'm getting rid of the
    function entirely.
    Signed-off-by: default avatarEric Paris <eparis@redhat.com>
    92ae9e82
selinuxfs.c 43.1 KB