• Alexander Aring's avatar
    dlm: warn about invalid nodeid comparsions · d47b8229
    Alexander Aring authored
    This patch adds a warn on if is_master() and dlm_is_removed() checks on
    invalid nodeid states that are probably not what the caller wants to do
    here. The is_master() function checking on r->res_nodeid is invalid when
    it is set to -1, whereas the dlm_is_removed() has a different meaning
    as "nodeid member" and also 0 is invalid.
    
    We run into these cases and this patch changes those cases as we never
    will run into them. There should be no functional changes as the
    condition should return the same result. However this patch signals now
    on caller level that there might be an "extra" case to handle here.
    Signed-off-by: default avatarAlexander Aring <aahringo@redhat.com>
    Signed-off-by: default avatarDavid Teigland <teigland@redhat.com>
    d47b8229
recover.c 22.1 KB