• Gustavo A. R. Silva's avatar
    liquidio: lio_vf_main: remove unnecessary static in setup_io_queues() · 93fe07e5
    Gustavo A. R. Silva authored
    Remove unnecessary static on local variables cpu_id_modulus and cpu_id.
    Such variables are initialized before being used, on every execution
    path throughout the function. The static has no benefit and, removing
    it reduces the object file size.
    
    This issue was detected using Coccinelle and the following semantic patch:
    
    @bad exists@
    position p;
    identifier x;
    type T;
    @@
    
    static T x@p;
    ...
    x = <+...x...+>
    
    @@
    identifier x;
    expression e;
    type T;
    position p != bad.p;
    @@
    
    -static
     T x@p;
     ... when != x
         when strict
    ?x = e;
    
    In the following log you can see a significant difference in the object
    file size. Also, there is a significant difference in the bss segment.
    This log is the output of the size command, before and after the code
    change:
    
    before:
       text    data     bss     dec     hex filename
      55656   10680     576   66912   10560 drivers/net/ethernet/cavium/liquidio/lio_vf_main.o
    
    after:
       text    data     bss     dec     hex filename
      55796   10536     448   66780   104dc drivers/net/ethernet/cavium/liquidio/lio_vf_main.o
    Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    93fe07e5
lio_vf_main.c 83.3 KB