• Zhihao Cheng's avatar
    ubifs: Re-statistic cleaned znode count if commit failed · 944e096a
    Zhihao Cheng authored
    Dirty znodes will be written on flash in committing process with
    following states:
    
    	      process A			|  znode state
    ------------------------------------------------------
    do_commit				| DIRTY_ZNODE
      ubifs_tnc_start_commit		| DIRTY_ZNODE
       get_znodes_to_commit			| DIRTY_ZNODE | COW_ZNODE
        layout_commit			| DIRTY_ZNODE | COW_ZNODE
         fill_gap                           | 0
      write master				| 0 or OBSOLETE_ZNODE
    
    	      process B			|  znode state
    ------------------------------------------------------
    do_commit				| DIRTY_ZNODE[1]
      ubifs_tnc_start_commit		| DIRTY_ZNODE
       get_znodes_to_commit			| DIRTY_ZNODE | COW_ZNODE
      ubifs_tnc_end_commit			| DIRTY_ZNODE | COW_ZNODE
       write_index                          | 0
      write master				| 0 or OBSOLETE_ZNODE[2] or
    					| DIRTY_ZNODE[3]
    
    [1] znode is dirtied without concurrent committing process
    [2] znode is copied up (re-dirtied by other process) before cleaned
        up in committing process
    [3] znode is re-dirtied after cleaned up in committing process
    
    Currently, the clean znode count is updated in free_obsolete_znodes(),
    which is called only in normal path. If do_commit failed, clean znode
    count won't be updated, which triggers a failure ubifs assertion[4] in
    ubifs_tnc_close():
     ubifs_assert_failed [ubifs]: UBIFS assert failed: freed == n
    
    [4] Commit 380347e9 ("UBIFS: Add an assertion for clean_zn_cnt").
    
    Fix it by re-statisticing cleaned znode count in tnc_destroy_cnext().
    
    Fetch a reproducer in [Link].
    
    Link: https://bugzilla.kernel.org/show_bug.cgi?id=216704
    Fixes: 1e51764a ("UBIFS: add new flash file system")
    Signed-off-by: default avatarZhihao Cheng <chengzhihao1@huawei.com>
    Signed-off-by: default avatarRichard Weinberger <richard@nod.at>
    944e096a
tnc.c 92.2 KB