• Dan Carpenter's avatar
    rt2x00: type bug in _rt2500usb_register_read() · 952348a5
    Dan Carpenter authored
    This code causes a static checker bug.
    
    drivers/net/wireless/ralink/rt2x00/rt2500usb.c:232 _rt2500usb_register_read()
    warn: passing casted pointer 'value' to 'rt2500usb_register_read()' 32 vs 16.
    
    If the low 16 bits were initialized to zero then this code would only be
    a problem on big endian systems.  But in this case this is case the low
    16 bits are never initialized.  This is called from a function which is
    created using a macro:
    
    RT2X00DEBUGFS_OPS(csr, "0x%.8x\n", u32);
    
    We end up copying uninitialized data to the user which is bogus and an
    information leak.
    Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
    Acked-by: default avatarStanislaw Gruszka <sgruszka@redhat.com>
    Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
    952348a5
rt2500usb.c 61.3 KB