• Arnd Bergmann's avatar
    netcp: fix regression in receive processing · 958d104e
    Arnd Bergmann authored
    A cleanup patch I did was unfortunately wrong and introduced
    multiple serious bugs in the netcp rx processing, as indicated
    by these correct gcc warnings:
    
    drivers/net/ethernet/ti/netcp_core.c:776:14: warning: 'buf_ptr' may be used uninitialized in this function [-Wuninitialized]
    drivers/net/ethernet/ti/netcp_core.c:687:14: warning: 'ptr' may be used uninitialized in this function [-Wuninitialized]
    
    I have checked the patch once more and found that a call to
    get_pkt_info() accidentally got removed in netcp_free_rx_desc_chain,
    and netcp_process_one_rx_packet no longer retrieved the correct
    buffer length. This patch should fix all the known problems,
    but I did not test on real hardware.
    Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
    Fixes: 89907779 ("netcp: try to reduce type confusion in descriptors")
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    958d104e
netcp_core.c 56.5 KB