• Boerge Struempfel's avatar
    gpiolib: sysfs: Fix error handling on failed export · 95dd1e34
    Boerge Struempfel authored
    If gpio_set_transitory() fails, we should free the GPIO again. Most
    notably, the flag FLAG_REQUESTED has previously been set in
    gpiod_request_commit(), and should be reset on failure.
    
    To my knowledge, this does not affect any current users, since the
    gpio_set_transitory() mainly returns 0 and -ENOTSUPP, which is converted
    to 0. However the gpio_set_transitory() function calles the .set_config()
    function of the corresponding GPIO chip and there are some GPIO drivers in
    which some (unlikely) branches return other values like -EPROBE_DEFER,
    and -EINVAL. In these cases, the above mentioned FLAG_REQUESTED would not
    be reset, which results in the pin being blocked until the next reboot.
    
    Fixes: e10f72bf ("gpio: gpiolib: Generalise state persistence beyond sleep")
    Signed-off-by: default avatarBoerge Struempfel <boerge.struempfel@gmail.com>
    Reviewed-by: default avatarAndy Shevchenko <andy@kernel.org>
    Signed-off-by: default avatarBartosz Golaszewski <bartosz.golaszewski@linaro.org>
    95dd1e34
gpiolib-sysfs.c 19.4 KB