• Linus Walleij's avatar
    ARM: nomadik: fix up double inversion in DT · 3181788c
    Linus Walleij authored
    The GPIO pin connected to card detect was inverted twice: once by
    the argument to the GPIO line itself where it was magically marked
    as active low by the flag GPIO_ACTIVE_LOW (0x01) in the third cell,
    and also marked active low AGAIN by explicitly stating
    "cd-inverted" (a deprecated method).
    
    After commit 78f87df2
    "mmc: mmci: Use the common mmc DT parser" this results in the
    line being inverted twice so it was effectively uninverted, while
    the old code would not have this effect, instead disregarding the
    flag on the GPIO line altogether, which is a bug. I admit the
    semantics may be unclear but inverting twice is as good a
    definition as any on how this should work.
    
    So fix up the buggy device tree. Use proper #includes so the DTS
    is clear and readable.
    
    Cc: Ulf Hansson <ulf.hansson@linaro.org>
    Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
    Signed-off-by: default avatarOlof Johansson <olof@lixom.net>
    3181788c
ste-nomadik-s8815.dts 2.01 KB