• Mel Gorman's avatar
    mm: revert "mm: vmscan: scale number of pages reclaimed by reclaim/compaction based on failures" · 96710098
    Mel Gorman authored
    Jiri Slaby reported the following:
    
    	(It's an effective revert of "mm: vmscan: scale number of pages
    	reclaimed by reclaim/compaction based on failures".) Given kswapd
    	had hours of runtime in ps/top output yesterday in the morning
    	and after the revert it's now 2 minutes in sum for the last 24h,
    	I would say, it's gone.
    
    The intention of the patch in question was to compensate for the loss of
    lumpy reclaim.  Part of the reason lumpy reclaim worked is because it
    aggressively reclaimed pages and this patch was meant to be a sane
    compromise.
    
    When compaction fails, it gets deferred and both compaction and
    reclaim/compaction is deferred avoid excessive reclaim.  However, since
    commit c6543459 ("mm: remove __GFP_NO_KSWAPD"), kswapd is woken up
    each time and continues reclaiming which was not taken into account when
    the patch was developed.
    
    Attempts to address the problem ended up just changing the shape of the
    problem instead of fixing it.  The release window gets closer and while
    a THP allocation failing is not a major problem, kswapd chewing up a lot
    of CPU is.
    
    This patch reverts commit 83fde0f2 ("mm: vmscan: scale number of
    pages reclaimed by reclaim/compaction based on failures") and will be
    revisited in the future.
    Signed-off-by: default avatarMel Gorman <mgorman@suse.de>
    Cc: Zdenek Kabelac <zkabelac@redhat.com>
    Tested-by: default avatarValdis Kletnieks <Valdis.Kletnieks@vt.edu>
    Cc: Jiri Slaby <jirislaby@gmail.com>
    Cc: Rik van Riel <riel@redhat.com>
    Cc: Jiri Slaby <jslaby@suse.cz>
    Cc: Johannes Hirte <johannes.hirte@fem.tu-ilmenau.de>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    96710098
vmscan.c 99.4 KB