• Willem de Bruijn's avatar
    tun: correct header offsets in napi frags mode · 96aa1b22
    Willem de Bruijn authored
    Tun in IFF_NAPI_FRAGS mode calls napi_gro_frags. Unlike netif_rx and
    netif_gro_receive, this expects skb->data to point to the mac layer.
    
    But skb_probe_transport_header, __skb_get_hash_symmetric, and
    xdp_do_generic in tun_get_user need skb->data to point to the network
    header. Flow dissection also needs skb->protocol set, so
    eth_type_trans has to be called.
    
    Ensure the link layer header lies in linear as eth_type_trans pulls
    ETH_HLEN. Then take the same code paths for frags as for not frags.
    Push the link layer header back just before calling napi_gro_frags.
    
    By pulling up to ETH_HLEN from frag0 into linear, this disables the
    frag0 optimization in the special case when IFF_NAPI_FRAGS is used
    with zero length iov[0] (and thus empty skb->linear).
    
    Fixes: 90e33d45 ("tun: enable napi_gro_frags() for TUN/TAP driver")
    Signed-off-by: default avatarWillem de Bruijn <willemb@google.com>
    Acked-by: default avatarPetar Penkov <ppenkov@google.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    96aa1b22
tun.c 85.6 KB