• Matthew Auld's avatar
    drm/xe: add lockdep annotation for xe_device_mem_access_put() · 9700a1df
    Matthew Auld authored
    The main motivation is with d3cold which will make the suspend and
    resume callbacks even more scary, but is useful regardless. We already
    have the needed annotation on the acquire side with
    xe_device_mem_access_get(), and by adding the annotation on the release
    side we should have a lot more confidence that our locking hierarchy is
    correct.
    
    v2:
      - Move the annotation into both callbacks for better symmetry. Also
        don't hold over the entire mem_access_get(); we only need to lockep
        to understand what is being held upon entering mem_access_get(), and
        how that matches up with locks in the callbacks.
    Signed-off-by: default avatarMatthew Auld <matthew.auld@intel.com>
    Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
    Cc: Anshuman Gupta <anshuman.gupta@intel.com>
    Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
    Reviewed-by: default avatarRodrigo Vivi <rodrigo.vivi@intel.com>
    Signed-off-by: default avatarRodrigo Vivi <rodrigo.vivi@intel.com>
    9700a1df
xe_device.c 10.9 KB