• Kevin Cernekee's avatar
    Fix signed/unsigned pointer warning · 97c7134a
    Kevin Cernekee authored
    Commit 2ae83bf9 ("[CIFS] Fix setting time before epoch (negative
    time values)") changed "u64 t" to "s64 t", which makes do_div() complain
    about a pointer signedness mismatch:
    
          CC      fs/cifs/netmisc.o
        In file included from ./arch/mips/include/asm/div64.h:12:0,
                         from include/linux/kernel.h:124,
                         from include/linux/list.h:8,
                         from include/linux/wait.h:6,
                         from include/linux/net.h:23,
                         from fs/cifs/netmisc.c:25:
        fs/cifs/netmisc.c: In function ‘cifs_NTtimeToUnix’:
        include/asm-generic/div64.h:43:28: warning: comparison of distinct pointer types lacks a cast [enabled by default]
          (void)(((typeof((n)) *)0) == ((uint64_t *)0)); \
                                    ^
        fs/cifs/netmisc.c:941:22: note: in expansion of macro ‘do_div’
           ts.tv_nsec = (long)do_div(t, 10000000) * 100;
    
    Introduce a temporary "u64 abs_t" variable to fix this.
    Signed-off-by: default avatarKevin Cernekee <cernekee@gmail.com>
    Signed-off-by: default avatarSteve French <steve.french@primarydata.com>
    97c7134a
netmisc.c 39.5 KB