• Jason Wang's avatar
    dpaa2-eth: Replace strlcpy with strscpy · 995786ba
    Jason Wang authored
    The strlcpy should not be used because it doesn't limit the source
    length. As linus says, it's a completely useless function if you
    can't implicitly trust the source string - but that is almost always
    why people think they should use it! All in all the BSD function
    will lead some potential bugs.
    
    But the strscpy doesn't require reading memory from the src string
    beyond the specified "count" bytes, and since the return value is
    easier to error-check than strlcpy()'s. In addition, the implementation
    is robust to the string changing out from underneath it, unlike the
    current strlcpy() implementation.
    
    Thus, We prefer using strscpy instead of strlcpy.
    Signed-off-by: default avatarJason Wang <wangborong@cdjrlc.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    995786ba
dpaa2-ethtool.c 21.8 KB