• Mark Rutland's avatar
    arm64: extable: add a dedicated uaccess handler · 2e77a62c
    Mark Rutland authored
    For inline assembly, we place exception fixups out-of-line in the
    `.fixup` section such that these are out of the way of the fast path.
    This has a few drawbacks:
    
    * Since the fixup code is anonymous, backtraces will symbolize fixups as
      offsets from the nearest prior symbol, currently
      `__entry_tramp_text_end`. This is confusing, and painful to debug
      without access to the relevant vmlinux.
    
    * Since the exception handler adjusts the PC to execute the fixup, and
      the fixup uses a direct branch back into the function it fixes,
      backtraces of fixups miss the original function. This is confusing,
      and violates requirements for RELIABLE_STACKTRACE (and therefore
      LIVEPATCH).
    
    * Inline assembly and associated fixups are generated from templates,
      and we have many copies of logically identical fixups which only
      differ in which specific registers are written to and which address is
      branched to at the end of the fixup. This is potentially wasteful of
      I-cache resources, and makes it hard to add additional logic to fixups
      without significant bloat.
    
    This patch address all three concerns for inline uaccess fixups by
    adding a dedicated exception handler which updates registers in
    exception context and subsequent returns back into the function which
    faulted, removing the need for fixups specialized to each faulting
    instruction.
    
    Other than backtracing, there should be no functional change as a result
    of this patch.
    Signed-off-by: default avatarMark Rutland <mark.rutland@arm.com>
    Reviewed-by: default avatarArd Biesheuvel <ardb@kernel.org>
    Cc: Catalin Marinas <catalin.marinas@arm.com>
    Cc: James Morse <james.morse@arm.com>
    Cc: Robin Murphy <robin.murphy@arm.com>
    Cc: Will Deacon <will@kernel.org>
    Link: https://lore.kernel.org/r/20211019160219.5202-12-mark.rutland@arm.comSigned-off-by: default avatarWill Deacon <will@kernel.org>
    2e77a62c
uaccess.h 11.7 KB