• Mark Rutland's avatar
    arm64: extable: add load_unaligned_zeropad() handler · 753b3236
    Mark Rutland authored
    For inline assembly, we place exception fixups out-of-line in the
    `.fixup` section such that these are out of the way of the fast path.
    This has a few drawbacks:
    
    * Since the fixup code is anonymous, backtraces will symbolize fixups as
      offsets from the nearest prior symbol, currently
      `__entry_tramp_text_end`. This is confusing, and painful to debug
      without access to the relevant vmlinux.
    
    * Since the exception handler adjusts the PC to execute the fixup, and
      the fixup uses a direct branch back into the function it fixes,
      backtraces of fixups miss the original function. This is confusing,
      and violates requirements for RELIABLE_STACKTRACE (and therefore
      LIVEPATCH).
    
    * Inline assembly and associated fixups are generated from templates,
      and we have many copies of logically identical fixups which only
      differ in which specific registers are written to and which address is
      branched to at the end of the fixup. This is potentially wasteful of
      I-cache resources, and makes it hard to add additional logic to fixups
      without significant bloat.
    
    * In the case of load_unaligned_zeropad(), the logic in the fixup
      requires a temporary register that we must allocate even in the
      fast-path where it will not be used.
    
    This patch address all four concerns for load_unaligned_zeropad() fixups
    by adding a dedicated exception handler which performs the fixup logic
    in exception context and subsequent returns back after the faulting
    instruction. For the moment, the fixup logic is identical to the old
    assembly fixup logic, but in future we could enhance this by taking the
    ESR and FAR into account to constrain the faults we try to fix up, or to
    specialize fixups for MTE tag check faults.
    
    Other than backtracing, there should be no functional change as a result
    of this patch.
    Signed-off-by: default avatarMark Rutland <mark.rutland@arm.com>
    Reviewed-by: default avatarArd Biesheuvel <ardb@kernel.org>
    Cc: Catalin Marinas <catalin.marinas@arm.com>
    Cc: James Morse <james.morse@arm.com>
    Cc: Robin Murphy <robin.murphy@arm.com>
    Cc: Will Deacon <will@kernel.org>
    Link: https://lore.kernel.org/r/20211019160219.5202-13-mark.rutland@arm.comSigned-off-by: default avatarWill Deacon <will@kernel.org>
    753b3236
extable.c 1.94 KB