• Luiz Angelo Daros de Luca's avatar
    net: dsa: realtek: realtek-smi: clean-up reset · 9a236b54
    Luiz Angelo Daros de Luca authored
    When reset GPIO was missing, the driver was still printing an info
    message and still trying to assert the reset. Although gpiod_set_value()
    will silently ignore calls with NULL gpio_desc, it is better to make it
    clear the driver might allow gpio_desc to be NULL.
    
    The initial value for the reset pin was changed to GPIOD_OUT_LOW,
    followed by a gpiod_set_value() asserting the reset. This way, it will
    be easier to spot if and where the reset really happens.
    
    A new "asserted RESET" message was added just after the reset is
    asserted, similar to the existing "deasserted RESET" message. Both
    messages were demoted to dbg. The code comment is not needed anymore.
    Signed-off-by: default avatarLuiz Angelo Daros de Luca <luizluca@gmail.com>
    Acked-by: default avatarArınç ÜNAL <arinc.unal@arinc9.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    9a236b54
realtek-smi.c 12.6 KB