• Toshi Kani's avatar
    x86/mm: Remove region_is_ram() call from ioremap · 9a58eebe
    Toshi Kani authored
    __ioremap_caller() calls region_is_ram() to walk through the
    iomem_resource table to check if a target range is in RAM, which was
    added to improve the lookup performance over page_is_ram() (commit
    906e36c5 "x86: use optimized ioresource lookup in ioremap
    function"). page_is_ram() was no longer used when this change was
    added, though.
    
    __ioremap_caller() then calls walk_system_ram_range(), which had
    replaced page_is_ram() to improve the lookup performance (commit
    c81c8a1e "x86, ioremap: Speed up check for RAM pages").
    
    Since both checks walk through the same iomem_resource table for
    the same purpose, there is no need to call both functions.
    
    Aside of that walk_system_ram_range() is the only useful check at the
    moment because region_is_ram() always returns -1 due to an
    implementation bug. That bug in region_is_ram() cannot be fixed
    without breaking existing ioremap callers, which rely on the subtle
    difference of walk_system_ram_range() versus non page aligned ranges.
    
    Once these offending callers are fixed we can use region_is_ram() and
    remove walk_system_ram_range().
    
    [ tglx: Massaged changelog ]
    Signed-off-by: default avatarToshi Kani <toshi.kani@hp.com>
    Reviewed-by: default avatarDan Williams <dan.j.williams@intel.com>
    Cc: Roland Dreier <roland@purestorage.com>
    Cc: Mike Travis <travis@sgi.com>
    Cc: Luis R. Rodriguez <mcgrof@suse.com>
    Cc: H. Peter Anvin <hpa@zytor.com>
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: Borislav Petkov <bp@alien8.de>
    Cc: linux-mm@kvack.org
    Link: http://lkml.kernel.org/r/1437088996-28511-3-git-send-email-toshi.kani@hp.comSigned-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
    9a58eebe
ioremap.c 13.8 KB