• Tony Lindgren's avatar
    phy: mapphone-mdm6600: Fix pinctrl_pm handling for sleep pins · 3b384cc7
    Tony Lindgren authored
    Looks like the driver sleep pins configuration is unusable. Adding the
    sleep pins causes the usb phy to not respond. We need to use the default
    pins in probe, and only set sleep pins at phy_mdm6600_device_power_off().
    
    As the modem can also be booted to a serial port mode for firmware
    flashing, let's make the pin changes limited to probe and remove. For
    probe, we get the default pins automatically. We only need to set the
    sleep pins in phy_mdm6600_device_power_off() to prevent the modem from
    waking up because the gpio line glitches.
    
    If it turns out that we need a separate state for phy_mdm6600_power_on()
    and phy_mdm6600_power_off(), we can use the pinctrl idle state.
    
    Cc: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
    Cc: Merlijn Wajer <merlijn@wizzup.org>
    Cc: Pavel Machek <pavel@ucw.cz>
    Cc: Sebastian Reichel <sre@kernel.org>
    Fixes: 2ad2af08 ("phy: mapphone-mdm6600: Improve phy related runtime PM calls")
    Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
    Reviewed-by: default avatarSebastian Reichel <sebastian.reichel@collabora.com>
    Link: https://lore.kernel.org/r/20230913060433.48373-3-tony@atomide.comSigned-off-by: default avatarVinod Koul <vkoul@kernel.org>
    3b384cc7
phy-mapphone-mdm6600.c 18.1 KB