• Serge Semin's avatar
    spi: Clear SPI_CS_HIGH flag from bad_bits for GPIO chip-select · d61ad23c
    Serge Semin authored
    When GPIO chip-select is used nothing prevents any available SPI
    controllers to work with both CS-high and traditional CS-low modes.
    In fact the SPI bus core code already does it, so we don't need to
    introduce any modification there. But spi_setup() still fails to
    switch the interface settings if CS-high flag is set for the case
    of GPIO-driven slave chip-select when the SPI controller doesn't
    support the hardwired CS-inversion. Lets fix it by clearing the
    SPI_CS_HIGH flag out from bad_bits (unsupported by controller) when
    client chip is selected by GPIO.
    
    This feature is useful for slave devices, which in accordance with
    communication protocol can work with both active-high and active-low
    chip-selects. I am aware of one such device. It is MMC-SPI interface,
    when at init sequence the driver needs to perform a read operation with
    low and high chip-select sequentially (requirement of 74 clock cycles
    with both chipselect, see the mmc_spi driver for details).
    Signed-off-by: default avatarSerge Semin <fancer.lancer@gmail.com>
    Signed-off-by: default avatarMark Brown <broonie@kernel.org>
    d61ad23c
spi.c 100 KB