• Dan Williams's avatar
    PM: CXL: Disable suspend · 9ea4dcf4
    Dan Williams authored
    The CXL specification claims S3 support at a hardware level, but at a
    system software level there are some missing pieces. Section 9.4 (CXL
    2.0) rightly claims that "CXL mem adapters may need aux power to retain
    memory context across S3", but there is no enumeration mechanism for the
    OS to determine if a given adapter has that support. Moreover the save
    state and resume image for the system may inadvertantly end up in a CXL
    device that needs to be restored before the save state is recoverable.
    I.e. a circular dependency that is not resolvable without a third party
    save-area.
    
    Arrange for the cxl_mem driver to fail S3 attempts. This still nominaly
    allows for suspend, but requires unbinding all CXL memory devices before
    the suspend to ensure the typical DRAM flow is taken. The cxl_mem unbind
    flow is intended to also tear down all CXL memory regions associated
    with a given cxl_memdev.
    
    It is reasonable to assume that any device participating in a System RAM
    range published in the EFI memory map is covered by aux power and
    save-area outside the device itself. So this restriction can be
    minimized in the future once pre-existing region enumeration support
    arrives, and perhaps a spec update to clarify if the EFI memory map is
    sufficent for determining the range of devices managed by
    platform-firmware for S3 support.
    
    Per Rafael, if the CXL configuration prevents suspend then it should
    fail early before tasks are frozen, and mem_sleep should stop showing
    'mem' as an option [1]. Effectively CXL augments the platform suspend
    ->valid() op since, for example, the ACPI ops are not aware of the CXL /
    PCI dependencies. Given the split role of platform firmware vs OS
    provisioned CXL memory it is up to the cxl_mem driver to determine if
    the CXL configuration has elements that platform firmware may not be
    prepared to restore.
    
    Link: https://lore.kernel.org/r/CAJZ5v0hGVN_=3iU8OLpHY3Ak35T5+JcBM-qs8SbojKrpd0VXsA@mail.gmail.com [1]
    Cc: "Rafael J. Wysocki" <rafael@kernel.org>
    Cc: Pavel Machek <pavel@ucw.cz>
    Cc: Len Brown <len.brown@intel.com>
    Reviewed-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
    Link: https://lore.kernel.org/r/165066828317.3907920.5690432272182042556.stgit@dwillia2-desk3.amr.corp.intel.comSigned-off-by: default avatarDan Williams <dan.j.williams@intel.com>
    9ea4dcf4
hibernate.c 30.3 KB