• Arnd Bergmann's avatar
    netcp: add more __le32 annotations · 9dd2d6c5
    Arnd Bergmann authored
    The handling of epib and psdata remains a bit unclear in the driver,
    as we access the same fields both as CPU-endian and through DMA
    from the device.
    
    Sparse warns about this:
    ti/netcp_core.c:1147:21: warning: incorrect type in assignment (different base types)
    ti/netcp_core.c:1147:21:    expected unsigned int [usertype] *[assigned] epib
    ti/netcp_core.c:1147:21:    got restricted __le32 *<noident>
    
    This uses __le32 types in a few places and uses __force where the code
    looks fishy. The previous patch should really have produced the correct
    behavior, but this second patch is needed to shut up the warnings about
    it. Ideally it would be slightly rewritten to not need those casts,
    but I don't dare do that without access to the hardware for proper
    testing.
    Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    9dd2d6c5
netcp_core.c 56.3 KB