• Arnd Bergmann's avatar
    media: verisilicon: change confusingly named relaxed register access · 0cb1d9c8
    Arnd Bergmann authored
    The register abstraction has wrappers around both the normal writel()
    and its writel_relaxed() counterpart, but this has led to a lot of users
    ending up with the relaxed version.
    
    There is sometimes a need to intentionally pick the relaxed accessor for
    performance critical functions, but I noticed that each hantro_reg_write()
    call also contains a non-relaxed readl(), which is typically much more
    expensive than a writel, so there is little benefit here but an added
    risk of missing a serialization against DMA.
    
    To make this behave like other interfaces, use the normal accessor by
    default and only provide the relaxed version as an alternative for
    performance critical code. hantro_postproc.c is the only place that
    used both the relaxed and normal writel, but this does not seem
    cricital either, so change it all to the normal ones.
    
    [hverkuil: fix function prototype alignment]
    Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
    Tested-by: default avatarBenjamin Gaignard <benjamin.gaignard@collabora.com>
    Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
    Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@kernel.org>
    0cb1d9c8
hantro_postproc.c 8.33 KB