• Robert Hancock's avatar
    net: axienet: Use NAPI for TX completion path · 9e2bc267
    Robert Hancock authored
    This driver was using the TX IRQ handler to perform all TX completion
    tasks. Under heavy TX network load, this can cause significant irqs-off
    latencies (found to be in the hundreds of microseconds using ftrace).
    This can cause other issues, such as overrunning serial UART FIFOs when
    using high baud rates with limited UART FIFO sizes.
    
    Switch to using a NAPI poll handler to perform the TX completion work
    to get this out of hard IRQ context and avoid the IRQ latency impact.
    A separate poll handler is used for TX and RX since they have separate
    IRQs on this controller, so that the completion work for each of them
    stays on the same CPU as the interrupt.
    
    Testing on a Xilinx MPSoC ZU9EG platform using iperf3 from a Linux PC
    through a switch at 1G link speed showed no significant change in TX or
    RX throughput, with approximately 941 Mbps before and after. Hard IRQ
    time in the TX throughput test was significantly reduced from 12% to
    below 1% on the CPU handling TX interrupts, with total hard+soft IRQ CPU
    usage dropping from about 56% down to 48%.
    Signed-off-by: default avatarRobert Hancock <robert.hancock@calian.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    9e2bc267
xilinx_axienet.h 22.1 KB