• Ritesh Harjani (IBM)'s avatar
    iomap: Allocate ifs in ->write_begin() early · a01b8f22
    Ritesh Harjani (IBM) authored
    We dont need to allocate an ifs in ->write_begin() for writes where the
    position and length completely overlap with the given folio.
    Therefore, such cases are skipped.
    
    Currently when the folio is uptodate, we only allocate ifs at writeback
    time (in iomap_writepage_map()). This is ok until now, but when we are
    going to add support for per-block dirty state bitmap in ifs, this
    could cause some performance degradation. The reason is that if we don't
    allocate ifs during ->write_begin(), then we will never mark the
    necessary dirty bits in ->write_end() call. And we will have to mark all
    the bits as dirty at the writeback time, that could cause the same write
    amplification and performance problems as it is now.
    Signed-off-by: default avatarRitesh Harjani (IBM) <ritesh.list@gmail.com>
    Reviewed-by: default avatarDarrick J. Wong <djwong@kernel.org>
    Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
    a01b8f22
buffered-io.c 53.5 KB