• Alex Elder's avatar
    net: ipa: fix init header command validation · b4afd4b9
    Alex Elder authored
    We use ipa_cmd_header_valid() to ensure certain values we will
    program into hardware are within range, well in advance of when we
    actually program them.  This way we avoid having to check for errors
    when we actually program the hardware.
    
    Unfortunately the dev_err() call for a bad offset value does not
    supply the arguments to match the format specifiers properly.
    Fix this.
    
    There was also supposed to be a check to ensure the size to be
    programmed fits in the field that holds it.  Add this missing check.
    
    Rearrange the way we ensure the header table fits in overall IPA
    memory range.
    
    Finally, update ipa_cmd_table_valid() so the format of messages
    printed for errors matches what's done in ipa_cmd_header_valid().
    Signed-off-by: default avatarAlex Elder <elder@linaro.org>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    b4afd4b9
ipa_cmd.c 21.5 KB